Merged
Conversation
Contributor
|
Thanks for this PR, unfortunately we can only accept signed commits can you please sign your commit and we can get this merged thanks? |
roe85
force-pushed
the
dependency-cleanup
branch
2 times, most recently
from
e0ddc3a to
fb974b9
Compare
Contributor
Author
done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement
Boost.Iostreams was not actually used.
The CMake dependencies to ASIO and its dependencies have not been established.
Proposed changes
Remove Boost.Iostreams includes and vcpkg dependencies.
Add
target_link_libraryto the header-only targetBoost::boost.